Skip to content

Remove extra table of contents from asyncio-task #22275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

verhovsky
Copy link
Contributor

No description provided.

@1st1
Copy link
Member

1st1 commented Sep 16, 2020

Please elaborate what this change actually does to the rendered docs. It's hard to review without building the docs on my machine and I don't have time for that, unfortunately :/

@verhovsky
Copy link
Contributor Author

If you go to https://docs.python.org/3/library/asyncio-task.html right now, it has a table of contents in the sidebar as well as on the page itself. This extra contents page also causes all the headings to become blue underlined hyperlinks instead of normal bold text that displays a link icon when you mouse over the heading like the rest of the documentation.

Before and after: https://imgur.com/a/jSUrjBy

@1st1
Copy link
Member

1st1 commented Sep 16, 2020

If you go to https://docs.python.org/3/library/asyncio-task.html right now, it has a table of contents in the sidebar as well as on the page itself. This extra contents page also causes all the headings to become blue underlined hyperlinks instead of normal bold text that displays a link icon when you mouse over the heading like the rest of the documentation.

Yeah, that's not a bug - I designed it that way. Closing this, but thanks for the PR!

@1st1 1st1 closed this Sep 16, 2020
@verhovsky verhovsky changed the title Remove asyncio-task contents Remove extra table of contents from asyncio-task Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants