Skip to content

[3.9] bpo-41302: Fix build with system libmpdec (GH-21481) #21486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 15, 2020

Move definition of UNUSED from modified headers of libmpdec to
_decimal.c itself. This makes the vendored source closer to the
standalone library and fixes build with --with-system-libmpdec.

Tested to build fine with either system libmpdec or the vendored one.
(cherry picked from commit 015efdb)

Co-authored-by: Felix Yan [email protected]

https://bugs.python.org/issue41302

Move definition of UNUSED from modified headers of libmpdec to
_decimal.c itself. This makes the vendored source closer to the
standalone library and fixes build with --with-system-libmpdec.

Tested to build fine with either system libmpdec or the vendored one.
(cherry picked from commit 015efdb)

Co-authored-by: Felix Yan <[email protected]>
@miss-islington
Copy link
Contributor Author

@felixonmars and @skrah: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8ca63f9 into python:3.9 Jul 15, 2020
@miss-islington miss-islington deleted the backport-015efdb-3.9 branch July 15, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants