Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 14, 2020

GH-msg373510

[bpo-32528]()/GH-13528 changed asyncio.CancelledError such that it no longer inherits from concurrent.futures.CancelledError. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist [email protected]

https://bugs.python.org/issue32528

…or (pythonGH-21474)

GH-msg373510

[bpo-32528]()/pythonGH-13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist <[email protected]>
@miss-islington
Copy link
Contributor Author

@JustAnotherArchivist: Status check is done, and it's a success ✅ .

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc: @1st1 as it's a backport of the change previously automerged.

@miss-islington miss-islington merged commit 700cb66 into python:3.8 Jul 19, 2020
@miss-islington miss-islington deleted the backport-2a51818-3.8 branch July 19, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants