-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-40807: Show warnings once from codeop._maybe_compile #20486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After writing the comments, did some more experiments with the REPL that suggest the need for different or maybe just additional changes somewhere (here? code.II?, IDLE?). I will report on the issue tomorrow. Consider these for now.
When you're done making the requested changes, leave the comment: |
I have made the requested changes; please review again. |
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
I am adding the News entry and will merge when possible, and then finish the IDLE fix that requires this. |
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9. |
@terryjreedy: Please replace |
GH-20639 is a backport of this pull request to the 3.9 branch. |
GH-20640 is a backport of this pull request to the 3.8 branch. |
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
GH-20672 is a backport of this pull request to the 3.8 branch. |
) * bpo-40807: Show warnings once from codeop._maybe_compile * Move catch_warnings * news Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit 052d3fc) Co-authored-by: Cheryl Sabella <[email protected]>
) * bpo-40807: Show warnings once from codeop._maybe_compile * Move catch_warnings * news Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit 052d3fc) Co-authored-by: Cheryl Sabella <[email protected]>
GH-20673 is a backport of this pull request to the 3.7 branch. |
* bpo-40807: Show warnings once from codeop._maybe_compile * Move catch_warnings * news Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit 052d3fc) Co-authored-by: Cheryl Sabella <[email protected]>
|
|
* bpo-40807: Show warnings once from codeop._maybe_compile * Move catch_warnings * news Co-authored-by: Terry Jan Reedy <[email protected]>
It seems like this change introduced a regression, would you mind to have a look at https://bugs.python.org/issue41520 ? cc @csabella |
https://bugs.python.org/issue40807