-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-40723: Make IDLE autocomplete test run without __main__.__file__ #20311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A contributor may and usually should add a draft MISC/NEWS.d/next/<section>/<title>.rst
file. Edits to idllelib/NEWS.txt need to be made soon before merging because each edit must wait until the previous edit is merged and pulled to a local directory. The change is then pushed to the PR branch. I usually do the latter, and do a final check of the blurb, after I have decided to do the merge. If 2 PRs have a NEWS.txt edit, which will be in the same place, then when one is merged, the other will have a merge conflict because of the change of context. Prior to moving to github and adding blurb, all news items were added to one file and we had the same issue even with multiple sections. It was a mess. I have sometimes left off NEWS.txt changes from a PR and done them in batches.
Thanks for the information @terryjreedy! And thanks more accepting. |
Thanks @DahlitzFlorian for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9. |
GH-20350 is a backport of this pull request to the 3.9 branch. |
…ythonGH-20311) This was the only failure running unittest.main(test.test_idle) after imports. (cherry picked from commit 905b3cd) Co-authored-by: Florian Dahlitz <[email protected]>
…ythonGH-20311) This was the only failure running unittest.main(test.test_idle) after imports. (cherry picked from commit 905b3cd) Co-authored-by: Florian Dahlitz <[email protected]>
GH-20351 is a backport of this pull request to the 3.8 branch. |
…ythonGH-20311) This was the only failure running unittest.main(test.test_idle) after imports. (cherry picked from commit 905b3cd) Co-authored-by: Florian Dahlitz <[email protected]>
GH-20352 is a backport of this pull request to the 3.7 branch. |
…H-20311) This was the only failure running unittest.main(test.test_idle) after imports. (cherry picked from commit 905b3cd) Co-authored-by: Florian Dahlitz <[email protected]>
…H-20311) This was the only failure running unittest.main(test.test_idle) after imports. (cherry picked from commit 905b3cd) Co-authored-by: Florian Dahlitz <[email protected]>
…H-20311) This was the only failure running unittest.main(test.test_idle) after imports. (cherry picked from commit 905b3cd) Co-authored-by: Florian Dahlitz <[email protected]>
…ythonGH-20311) This was the only failure running unittest.main(test.test_idle) after imports.
Apply the fix suggested by @terryjreedy in the corresponding issue's discussion (https://bugs.python.org/issue40723).
https://bugs.python.org/issue40723