Skip to content

bpo-40334: Disallow invalid single statements in the new parser #19774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2020

Conversation

lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Apr 28, 2020

After parsing is done, a single statement has to be checked for
additional lines and a SyntaxError must be raised, in case there
are any.

Closes we-like-parsers#99.

https://bugs.python.org/issue40334

After parsing is done, a single statement has to be checked for
additional lines and a `SyntaxError` must be raised, in case there
are any.

Closes we-like-parsers#99.
@lysnikolaou lysnikolaou marked this pull request as ready for review April 29, 2020 00:16
Co-Authored-By: Pablo Galindo <[email protected]>
@pablogsal
Copy link
Member

Nice work! One test less to go :)

@lysnikolaou
Copy link
Member Author

One test less to go :)

Yup! We're slowly getting there!

@pablogsal pablogsal merged commit 6d65087 into python:master Apr 29, 2020
@lysnikolaou lysnikolaou deleted the invalid-single-statements branch April 29, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiline single statement is allowed
4 participants