Skip to content

bpo-40140: test_builtin.PtyTests registers SIGHUP handler #19314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2020
Merged

bpo-40140: test_builtin.PtyTests registers SIGHUP handler #19314

merged 1 commit into from
Apr 2, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 2, 2020

test_builtin.PtyTests now registers an handler for SIGHUP signal.
Closing the PTY file descriptor can emit a SIGHUP signal: just ignore
it.

https://bugs.python.org/issue40140

test_builtin.PtyTests now registers an handler for SIGHUP signal.
Closing the PTY file descriptor can emit a SIGHUP signal: just ignore
it.

run_child() now also closes the PTY file descriptor before waiting
for the process completition, otherwise the test hangs on AIX.
@vstinner vstinner merged commit 7a51a7e into python:master Apr 2, 2020
@vstinner vstinner deleted the pty_tests_sighup branch April 2, 2020 22:40
vstinner added a commit that referenced this pull request Apr 3, 2020
…H-19316)

test_builtin.PtyTests now registers an handler for SIGHUP signal.
Closing the PTY file descriptor can emit a SIGHUP signal: just ignore
it.

run_child() now also closes the PTY file descriptor before waiting
for the process completition, otherwise the test hangs on AIX.

(cherry picked from commit 7a51a7e)
vstinner added a commit that referenced this pull request Apr 3, 2020
…H-19316) (GH-19318)

test_builtin.PtyTests now registers an handler for SIGHUP signal.
Closing the PTY file descriptor can emit a SIGHUP signal: just ignore
it.

run_child() now also closes the PTY file descriptor before waiting
for the process completition, otherwise the test hangs on AIX.

(cherry picked from commit 7a51a7e)
(cherry picked from commit 745bd91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants