Skip to content

bpo-31160: Fix test_builtin.test_input_no_stdout_fileno() #19312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bpo-31160: Fix test_builtin.test_input_no_stdout_fileno() #19312

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 2, 2020

bpo-31160, bpo-40140, bpo-40155: Fix test_input_no_stdout_fileno() of
test_builtin.

test.support.wait_process() can now be called with exitcode=None to
not check the exit code. Moreover, it now returns the child process
exit code, so it can be checked in the caller.

https://bugs.python.org/issue31160

bpo-31160, bpo-40140, bpo-40155: Fix test_input_no_stdout_fileno() of
test_builtin.

test.support.wait_process() can now be called with exitcode=None to
not check the exit code. Moreover, it now returns the child process
exit code, so it can be checked in the caller.
@vstinner
Copy link
Member Author

vstinner commented Apr 2, 2020

This PR doesn't fix https://bugs.python.org/issue40140.

I abandon this PR in favor of PR 19314 which fix https://bugs.python.org/issue40140.

@vstinner vstinner closed this Apr 2, 2020
@vstinner vstinner deleted the test_input_no_stdout_fileno branch April 3, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants