-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-40013: Added documentation to csv.DictReader restval #19099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @brandfilt, LGTM. The docs for DictReader
should definitely explain the purpose of the restval parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Thanks @brandfilt for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
…GH-19099) (cherry picked from commit 4b3252c) Co-authored-by: Juhana Jauhiainen <[email protected]>
GH-19141 is a backport of this pull request to the 3.8 branch. |
GH-19142 is a backport of this pull request to the 3.7 branch. |
…GH-19099) (cherry picked from commit 4b3252c) Co-authored-by: Juhana Jauhiainen <[email protected]>
…) (GH-19141) (cherry picked from commit 4b3252c) Co-authored-by: Juhana Jauhiainen <[email protected]>
…) (GH-19142) (cherry picked from commit 4b3252c) Co-authored-by: Juhana Jauhiainen <[email protected]>
https://bugs.python.org/issue40013