bpo-1635741: Port _weakref extension module to multiphase initialization(PEP 489) #19084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Mar 20, 2020
| if (PyModule_AddObject(module, "ref", (PyObject *) &_PyWeakref_RefType) < 0) { | ||
| Py_DECREF(&_PyWeakref_RefType); | ||
| return -1; | ||
| } |
There was a problem hiding this comment.
@corona10: Ah, now I see that we would benefit of a helper function calling PyType_Ready() + _PyType_Name() + PyModule_AddObject() ;-)
There was a problem hiding this comment.
I will submit the PR for this :)
There was a problem hiding this comment.
I am looking forword this feature;)
In this case, _PyWeakref_RefType have been added much times(it is means this type have much objects name). it can use this feature too?
|
thanks, folks. |
vstinner
added a commit
that referenced
this pull request
Mar 23, 2020
…tialization (PEP 489) (GH-19084)" (#19128) bpo-1635741, bpo-40050: This reverts commit 8334f30.
|
I had to revert this change: #19128 Because it introduced a reference leak: https://bugs.python.org/issue40050 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue1635741