Skip to content

bpo-39517: fix runpy.run_path() when using pathlike objects #18699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kmaork
Copy link
Contributor

@kmaork kmaork commented Feb 29, 2020

@codecov
Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #18699 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #18699     +/-   ##
=========================================
  Coverage   82.13%   82.13%             
=========================================
  Files        1956     1955      -1     
  Lines      589974   584611   -5363     
  Branches    44484    44484             
=========================================
- Hits       484572   480173   -4399     
+ Misses      95750    94791    -959     
+ Partials     9652     9647      -5     
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Modules/_decimal/libmpdec/umodarith.h 80.76% <0.00%> (-19.24%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
... and 328 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc04a05...4d8e0e9. Read the comment docs.

@kmaork
Copy link
Contributor Author

kmaork commented Mar 1, 2020

Thank you for the review @zooba ! is there anything I still have to do before this is merged?

@zooba zooba merged commit 0911ea5 into python:master Mar 8, 2020
@miss-islington
Copy link
Contributor

Thanks @kmaork for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2020
@bedevere-bot
Copy link

GH-18862 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Mar 8, 2020
sthagen added a commit to sthagen/python-cpython that referenced this pull request Mar 8, 2020
bpo-39517: Allow runpy.run_path() to accept path-like objects (pythonGH-18699)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants