-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-38691: Ignore pythoncaseok tests #18627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That's why the PR #18314 was reverted: https://bugs.python.org/issue38691#msg362202 |
@vstinner ready for review |
Codecov Report
@@ Coverage Diff @@
## master #18627 +/- ##
===========================================
+ Coverage 82.13% 83.22% +1.09%
===========================================
Files 1955 1571 -384
Lines 584601 415387 -169214
Branches 44484 44488 +4
===========================================
- Hits 480156 345709 -134447
+ Misses 94793 60029 -34764
+ Partials 9652 9649 -3
Continue to review full report at Codecov.
|
@@ -0,0 +1 @@ | |||
Updated :meth:`importlib._bootstrap_external._make_relax_case` to ignore :envvar:`PYTHONCASEOK` when -E or -I flags are used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to avoid mentioning a private module (_bootstrap_external) in a public Changelog entry. Reuse the text that you wrote above:
The :mod:`importlib` module now ignores the :envvar:`PYTHONCASEOK`
environment variable when the :option:`-E` or :option:`-I` command line
options are being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vstinner Fixed.
Thanks, merged. |
bpo-38691 Ignore pythoncaseok tests
[3.9] bpo-38691 Added a switch to ignore PYTHONCASEOK when -E or -I flags passed (GH-18627)
https://bugs.python.org/issue38691