-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-39572:documented _total_ attribute of TypedDict #18554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18554 +/- ##
===========================================
+ Coverage 82.11% 83.19% +1.08%
===========================================
Files 1956 1571 -385
Lines 589145 414757 -174388
Branches 44447 44457 +10
===========================================
- Hits 483801 345075 -138726
+ Misses 95697 60030 -35667
- Partials 9647 9652 +5
Continue to review full report at Codecov.
|
Note that the importlib failure is pre-existing (and presumably being worked on). I'll try to review later, but I am going out of town for a ew days. |
Misc/NEWS.d/next/Documentation/2020-02-18-18-37-07.bpo-39572.CCtzy1.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attribute -> flag, and you’re golden.
Thanks @ananthan-123 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
GH-18556 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit ab6423f) Co-authored-by: ananthan-123 <[email protected]>
https://bugs.python.org/issue39572