Skip to content

bpo-32892: Update the documentation for handling constants in AST. #18514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2020

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 15, 2020

I included these changes in the PR for other AST changes #9605, but it was not merged in 3.8.

https://bugs.python.org/issue32892

Copy link
Member

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These might clarify the doc a bit

Co-Authored-By: Batuhan Taşkaya <[email protected]>
@serhiy-storchaka
Copy link
Member Author

Thank you for your corrections @isidentical! I always had problems with articles which are absent in my native language.

@serhiy-storchaka serhiy-storchaka merged commit 85a2eef into python:master Feb 17, 2020
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the ast-constant-docs branch February 17, 2020 09:03
@bedevere-bot
Copy link

GH-18534 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants