bpo-39639: remove suite node #18513
Merged
bpo-39639: remove suite node #18513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
force-pushed
the
bpo-39639
branch
from
61b7b0b to
1a0874e
Compare
brettcannon
requested review from
brettcannon,
serhiy-storchaka,
vstinner and
pablogsal
brettcannon
reviewed
Mar 3, 2020
brettcannon
approved these changes
Mar 3, 2020
|
I haven't touched the AST in a while, so it would be great if someone else can just double-check me. Otherwise, @isidentical , if no other review comes in by Friday just ping me and I will merge this. |
serhiy-storchaka
approved these changes
Mar 3, 2020
pablogsal
approved these changes
Mar 3, 2020
pablogsal
reviewed
Mar 3, 2020
Misc/NEWS.d/next/Core and Builtins/2020-02-15-15-29-34.bpo-39639.3mqJjm.rst
Outdated
Show resolved
Hide resolved
Co-Authored-By: Brett Cannon <[email protected]> Co-Authored-By: Pablo Galindo <[email protected]>
Co-Authored-By: Victor Stinner <[email protected]>
vstinner
reviewed
Mar 4, 2020
Misc/NEWS.d/next/Core and Builtins/2020-02-15-15-29-34.bpo-39639.3mqJjm.rst
Outdated
Show resolved
Hide resolved
|
@isidentical: Thanks for the doc update, it's now well better ;-) Thanks also for clearing the old dust of from the early age of Python ;) |
colesbury
referenced
this pull request
in colesbury/nogil
Oct 6, 2021
The AST "Suite" node is no longer used and it can be removed from the ASDL definition and related structures (compiler, visitors, ...). Co-Authored-By: Victor Stinner <[email protected]> Co-authored-by: Brett Cannon <[email protected]> Co-authored-by: Pablo Galindo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39639