Skip to content

bpo-21016: pydoc and trace use sysconfig #18476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020
Merged

bpo-21016: pydoc and trace use sysconfig #18476

merged 1 commit into from
Feb 12, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 12, 2020

bpo-21016, bpo-1294959: The pydoc and trace modules now use the
sysconfig module to get the path to the Python standard library, to
support uncommon installation path like /usr/lib64/python3.9/ on
Fedora.

https://bugs.python.org/issue21016

bpo-21016, bpo-1294959: The pydoc and trace modules now use the
sysconfig module to get the path to the Python standard library, to
support uncommon installation path like /usr/lib64/python3.9/ on
Fedora.

Co-Authored-By: Jan Matějek <[email protected]>
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #18476 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #18476     +/-   ##
=========================================
  Coverage   82.11%   82.12%             
=========================================
  Files        1956     1955      -1     
  Lines      589067   583723   -5344     
  Branches    44436    44436             
=========================================
- Hits       483723   479356   -4367     
+ Misses      95690    94718    -972     
+ Partials     9654     9649      -5     
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 324 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95905ce...088126e. Read the comment docs.

@vstinner vstinner merged commit 4fac7ed into python:master Feb 12, 2020
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@vstinner vstinner deleted the stdlib_path branch February 12, 2020 12:02
@bedevere-bot
Copy link

GH-18482 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2020
bpo-21016, bpo-1294959: The pydoc and trace modules now use the
sysconfig module to get the path to the Python standard library, to
support uncommon installation path like /usr/lib64/python3.9/ on
Fedora.

Co-Authored-By: Jan Matějek <[email protected]>
(cherry picked from commit 4fac7ed)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot
Copy link

GH-18483 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Feb 12, 2020
bpo-21016, bpo-1294959: The pydoc and trace modules now use the
sysconfig module to get the path to the Python standard library, to
support uncommon installation path like /usr/lib64/python3.9/ on
Fedora.

Co-Authored-By: Jan Matějek <[email protected]>
(cherry picked from commit 4fac7ed)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington added a commit that referenced this pull request Feb 12, 2020
bpo-21016, bpo-1294959: The pydoc and trace modules now use the
sysconfig module to get the path to the Python standard library, to
support uncommon installation path like /usr/lib64/python3.9/ on
Fedora.

Co-Authored-By: Jan Matějek <[email protected]>
(cherry picked from commit 4fac7ed)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL7 3.8 has failed when building commit ac6f4d2.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/147/builds/119) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac6f4d2) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/147/builds/119

Failed tests:

  • test_asyncio

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 8, done.        
remote: Counting objects:  12% (1/8)        
remote: Counting objects:  25% (2/8)        
remote: Counting objects:  37% (3/8)        
remote: Counting objects:  50% (4/8)        
remote: Counting objects:  62% (5/8)        
remote: Counting objects:  75% (6/8)        
remote: Counting objects:  87% (7/8)        
remote: Counting objects: 100% (8/8)        
remote: Counting objects: 100% (8/8), done.        
remote: Total 10 (delta 7), reused 7 (delta 7), pack-reused 2        
From https://github.com/python/cpython
 * branch            3.8        -> FETCH_HEAD
Reset branch '3.8'

/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Modules/_testcapimodule.c: In function ‘PyInit__testcapi’:
/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Modules/_testcapimodule.c:6216:5: warning: ‘tp_print’ is deprecated (declared at ./Include/cpython/object.h:260) [-Wdeprecated-declarations]
     MyList_Type.tp_print = 0;
     ^

test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_msilib skipped -- No module named '_msi'
test_devpoll skipped -- test works only on Solaris OS family
test_ioctl skipped -- Unable to open /dev/tty
test_startfile skipped -- object <module 'os' from '/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/os.py'> has no attribute 'startfile'
test_tk skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_winconsoleio skipped -- test only relevant on win32
test_ttk_guionly skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_tix skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_kqueue skipped -- test works only on BSD
stty: standard input: Inappropriate ioctl for device
test_winsound skipped -- No module named 'winsound'
test_winreg skipped -- No module named 'winreg'
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 7.067s

OK (skipped=2)
test_gdb skipped -- Couldn't find gdb on the path
Timeout (0:15:00)!
Thread 0x00007f12fda76740 (most recent call first):
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/selectors.py", line 468 in select
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/asyncio/base_events.py", line 1823 in _run_once
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/asyncio/base_events.py", line 570 in run_forever
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/asyncio/base_events.py", line 603 in run_until_complete
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/test_asyncio/test_subprocess.py", line 440 in test_cancel_make_subprocess_transport_exec
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/case.py", line 633 in _callTestMethod
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/case.py", line 676 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/case.py", line 736 in __call__
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/runner.py", line 176 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/support/__init__.py", line 2030 in _run_suite
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/support/__init__.py", line 2126 in run_unittest
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/runtest.py", line 209 in _test_module
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/runtest.py", line 234 in _runtest_inner2
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/runtest.py", line 270 in _runtest_inner
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/runtest.py", line 140 in _runtest
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/runtest.py", line 193 in runtest
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/runtest_mp.py", line 73 in run_tests_worker
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/main.py", line 654 in _main
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/main.py", line 634 in main
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/main.py", line 712 in main
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/regrtest.py", line 46 in _main
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/regrtest.py", line 50 in <module>
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/runpy.py", line 86 in _run_code
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/runpy.py", line 193 in _run_module_as_main
Timeout (0:15:00)!
Thread 0x00007fad16312740 (most recent call first):
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/selectors.py", line 468 in select
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/asyncio/base_events.py", line 1823 in _run_once
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/asyncio/base_events.py", line 570 in run_forever
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/asyncio/base_events.py", line 603 in run_until_complete
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/test_asyncio/test_subprocess.py", line 484 in test_close_kill_running
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/case.py", line 633 in _callTestMethod
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/case.py", line 676 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/case.py", line 736 in __call__
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/unittest/runner.py", line 176 in run
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/support/__init__.py", line 2030 in _run_suite
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/support/__init__.py", line 2126 in run_unittest
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/runtest.py", line 209 in _test_module
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/runtest.py", line 234 in _runtest_inner2
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/runtest.py", line 270 in _runtest_inner
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/runtest.py", line 153 in _runtest
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/runtest.py", line 193 in runtest
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/main.py", line 318 in rerun_failed_tests
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/main.py", line 691 in _main
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/main.py", line 634 in main
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/libregrtest/main.py", line 712 in main
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/test/__main__.py", line 2 in <module>
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/runpy.py", line 86 in _run_code
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL7-x86_64/build/Lib/runpy.py", line 193 in _run_module_as_main
make: *** [buildbottest] Error 1

sthagen added a commit to sthagen/python-cpython that referenced this pull request Feb 12, 2020
bpo-21016: pydoc and trace use sysconfig (pythonGH-18476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants