Skip to content

Move test_math tests #18098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Move test_math tests #18098

merged 1 commit into from
Jan 21, 2020

Conversation

vstinner
Copy link
Member

testPerm() and testComb() belong to MathTests, not to IsCloseTests().

test_nextafter() and test_ulp() now use assertIsNaN().

testPerm() and testComb() belong to MathTests, not to IsCloseTests().

test_nextafter() and test_ulp() now use assertIsNaN().
@vstinner
Copy link
Member Author

Once this PR will be merged into master, I will backport it manually to 3.8 (since 3.8 doesn't need the "test_nextafter() and test_ulp() now use assertIsNaN()" change).

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@vstinner vstinner merged commit 59e2d26 into python:master Jan 21, 2020
@vstinner vstinner deleted the move_testmath branch January 21, 2020 11:48
@vstinner
Copy link
Member Author

3.8 backport: #18102

vstinner added a commit that referenced this pull request Jan 21, 2020
testPerm() and testComb() belong to MathTests, not to IsCloseTests().

(cherry picked from commit 59e2d26)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
testPerm() and testComb() belong to MathTests, not to IsCloseTests().

test_nextafter() and test_ulp() now use assertIsNaN().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants