[3.8] bpo-38673: dont switch to ps2 if the line starts with comment or whitespace (GH-17421) #17516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…espace (pythonGH-17421) https://bugs.python.org/issue38673 (cherry picked from commit 109fc27) Co-authored-by: Batuhan Taşkaya <[email protected]>
gvanrossum
approved these changes
Dec 9, 2019
|
@ambv Is it okay to merge this for 3.8.1? |
|
@isidentical: Status check is done, and it's a success ✅ . |
|
@isidentical: Status check is done, and it's a success ✅ . |
1 similar comment
|
@isidentical: Status check is done, and it's a success ✅ . |
|
Yes, this will be in 3.8.1. |
|
Thanks @miss-islington for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
While one could argue about changing the behavior of 3.7.x at this point, this does seem to me to be allowable as a bug fix with a greater chance of preventing confusion than breaking anything. To me, the old behavior suggests that the comment is being continued by the presence of the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38673
(cherry picked from commit 109fc27)
Co-authored-by: Batuhan Taşkaya [email protected]
https://bugs.python.org/issue38673