bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines #17366
Conversation
A non-blank non-shell window should end with exactly one newline following something other than space, tab, or newline. It should then be ready to commit to the cpython repository.
terryjreedy
added
type-feature
|
I think that this is ready to merge, but will wait half a day before doing so and moving on to invoking rstrip on save. |
|
Spec was revised after patchcheck experiment. See bpo-36682. |
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
…H-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py. (cherry picked from commit 6bf644e) Co-authored-by: Terry Jan Reedy <[email protected]>
|
GH-17370 is a backport of this pull request to the 3.8 branch. |
|
GH-17371 is a backport of this pull request to the 3.7 branch. |
…H-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py. (cherry picked from commit 6bf644e) Co-authored-by: Terry Jan Reedy <[email protected]>
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7. |
|
Sorry, @terryjreedy, I could not cleanly backport this to |
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Sorry @terryjreedy, I had trouble checking out the |
…ythonGH-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py. (cherry picked from commit 6bf644e) Co-authored-by: Terry Jan Reedy <[email protected]>
|
GH-17379 is a backport of this pull request to the 3.7 branch. |
…ythonGH-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py. (cherry picked from commit 6bf644e) Co-authored-by: Terry Jan Reedy <[email protected]>
…H-17366) (#17379) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py. (cherry picked from commit 6bf644e) Co-authored-by: Terry Jan Reedy <[email protected]>
…H-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py. (cherry picked from commit 6bf644e) Co-authored-by: Terry Jan Reedy <[email protected]>
…GH-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py.
…GH-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py.
Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py.
https://bugs.python.org/issue38862