Skip to content

bpo-38586: setting logging.Handler .name property in fileConfig #16918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2019
Merged

bpo-38586: setting logging.Handler .name property in fileConfig #16918

merged 1 commit into from
Oct 31, 2019

Conversation

Lucas-C
Copy link
Contributor

@Lucas-C Lucas-C commented Oct 24, 2019 •
edited by bedevere-bot
Loading

cf. https://bugs.python.org/issue38586

Tested under Windows with:

.\python -m test -v -m test_config_set_handler_names test_logging

https://bugs.python.org/issue38586

@Lucas-C Lucas-C requested a review from vsajip as a code owner October 24, 2019 15:18
@Lucas-C Lucas-C changed the title bpo-issue38586: setting logging.Handler .name property in fileConfig bpo-38586: setting logging.Handler .name property in fileConfig Oct 24, 2019
corona10
corona10 requested changes Oct 24, 2019
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments for this PR.

@Lucas-C
Copy link
Contributor Author

Lucas-C commented Oct 24, 2019

Thanks for the review !
Comments addressed

@vsajip vsajip merged commit b15100f into python:master Oct 31, 2019
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@Lucas-C
bpo-38586: setting logging.Handler .name property in fileConfig (pyth…
ef34a8b 
…onGH-16918)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@Lucas-C @shihai1991
bpo-38586: setting logging.Handler .name property in fileConfig (pyth…
c5857c9 
…onGH-16918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 requested changes

@vsajip vsajip vsajip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lucas-C @vsajip @corona10 @the-knights-who-say-ni @bedevere-bot