bpo-38161: Removes _AwaitEvent from AsyncMock. #16443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisroach
changed the title
|
Going to push since we are still in beta and I want it gone before RC tomorrow. |
|
Thanks @lisroach for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 30, 2019
(cherry picked from commit 25e115e) Co-authored-by: Lisa Roach <[email protected]>
|
GH-16481 is a backport of this pull request to the 3.8 branch. |
lisroach
pushed a commit
that referenced
this pull request
Sep 30, 2019
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something we can add back in as a feature in the future, but for now I want to take it out. With the release of 3.8 coming up I don't think this is thought out well enough- I don't like the name, I'm struggling to document it, its not tested, and I'm not sure if it's worth getting stuck with an attribute we may have to make significant changes to in the future.
If someone really wants it in now that's fine, just make a PR adding all those things in for me :)
https://bugs.python.org/issue38161