-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Fix typo in dictobject comment #15814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @dalgarno and welcome!
LGTM, we just need to wait for a core developer to review this.
Since this is involving a code comment change, I'll classify this as a documentation PR.
@DinoV: Please replace |
GH-15828 is a backport of this pull request to the 3.8 branch. |
GH-15829 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 359143c) Co-authored-by: dalgarno <[email protected]>
Oh, I just created a thread for this PR... https://discuss.python.org/t/fixing-simple-typo-in-comment-not-document/2297 |
(cherry picked from commit 359143c) Co-authored-by: dalgarno <[email protected]>
(cherry picked from commit 359143c) Co-authored-by: dalgarno <[email protected]>
Hmm, I can understand the concern about the messy commit logs, but I would strongly disagree that we should not accept these types of PRs. I don't think we should explicitly encourage them, but code comment typo fixing PRs provide a great introduction into the CPython workflow for new contributors. Many first time contributors start out with typo fixes, and then move on to making more impactful changes once they become more familiar with the workflow. Also, if you want to go through the git log without seeing the typo fixes, you can simply use:
|
Fixes a small typo in the dictobject comment. No
bpo
as it's a trivial fix.