Skip to content

Fix typo in dictobject comment #15814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

dalgarno
Copy link
Contributor

@dalgarno dalgarno commented Sep 9, 2019

Fixes a small typo in the dictobject comment. Nobpo as it's a trivial fix.

@aeros aeros added the docs Documentation in the Doc dir label Sep 10, 2019
Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dalgarno and welcome!

LGTM, we just need to wait for a core developer to review this.

Since this is involving a code comment change, I'll classify this as a documentation PR.

@bedevere-bot
Copy link

@DinoV: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @dalgarno for the PR, and @DinoV for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15828 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-15829 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
(cherry picked from commit 359143c)

Co-authored-by: dalgarno <[email protected]>
@methane
Copy link
Member

methane commented Sep 10, 2019

Oh, I just created a thread for this PR...

https://discuss.python.org/t/fixing-simple-typo-in-comment-not-document/2297

miss-islington added a commit that referenced this pull request Sep 10, 2019
(cherry picked from commit 359143c)

Co-authored-by: dalgarno <[email protected]>
miss-islington added a commit that referenced this pull request Sep 10, 2019
(cherry picked from commit 359143c)

Co-authored-by: dalgarno <[email protected]>
@aeros
Copy link
Contributor

aeros commented Sep 10, 2019

@methane:

Oh, I just created a thread for this PR...

Hmm, I can understand the concern about the messy commit logs, but I would strongly disagree that we should not accept these types of PRs. I don't think we should explicitly encourage them, but code comment typo fixing PRs provide a great introduction into the CPython workflow for new contributors. Many first time contributors start out with typo fixes, and then move on to making more impactful changes once they become more familiar with the workflow.

Also, if you want to go through the git log without seeing the typo fixes, you can simply use:

git log --grep="typo" --invert-grep

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants