bpo-37976: Prevent shadowing of TypeError in zip() #15592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sir-sigurd
commented
Aug 29, 2019
Python/bltinmodule.c
Outdated
| @@ -2549,8 +2549,8 @@ zip_new(PyTypeObject *type, PyObject *args, PyObject *kwds) | |||
| PyObject *it = PyObject_GetIter(item); | |||
| if (it == NULL) { | |||
| if (PyErr_ExceptionMatches(PyExc_TypeError)) | |||
There was a problem hiding this comment.
Might make sense to do the same for all exceptions types, but I'm not sure if it's OK for compatibility.
sir-sigurd
force-pushed
the
zip-shadow-error
branch
from
271651a to
756ca31
Compare
rhettinger
approved these changes
Aug 30, 2019
|
Thanks @sir-sigurd for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 30, 2019
(cherry picked from commit 6a650aa) Co-authored-by: Sergey Fedoseev <[email protected]>
|
GH-15607 is a backport of this pull request to the 3.8 branch. |
|
Thanks @sir-sigurd for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Thanks @sir-sigurd for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-15608 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 30, 2019
(cherry picked from commit 6a650aa) Co-authored-by: Sergey Fedoseev <[email protected]>
rhettinger
pushed a commit
that referenced
this pull request
Aug 30, 2019
(cherry picked from commit 6a650aa) Co-authored-by: Sergey Fedoseev <[email protected]>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37976