bpo-23878: Remove the key parameter of _Py_FindEnvConfigValue() #15555
Conversation
| @@ -734,8 +734,7 @@ _PyPathConfig_ComputeSysPath0(const PyWideStringList *argv, PyObject **path0_p) | |||
| /* Search for a prefix value in an environment file (pyvenv.cfg). | |||
There was a problem hiding this comment.
It doesn't search "for a prefix". It searchs for the the line "home=" and return <path>. It tolerates whitespaces around "=".
vstinner
changed the title
|
IMO it's fine to reuse https://bugs.python.org/issue23878 for this cleanup change. It gives more context about this change, than no bpo number. |
There was a problem hiding this comment.
If we're going to remove the key argument, we should also rename the function to reflect that it only finds home somehow.
Personally, I see no benefit here, and we may as well leave it alone. But if others think it's cleaner to have _Py_FindEnvConfigHomeValue instead of specifying L"home" in the call, I'm not going to fight it.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
|
@ZackerySpytz, please resolve the merge conflicts and address the code review. If this change is no longer relevant, please close the PR. Thanks! |
|
@ZackerySpytz ping |
|
https://bugs.python.org/issue23878 is closed. What is that status of this PR? |
|
This PR is still relevant, but it's outdated. @ZackerySpytz: can you please rebase it on the main branch? Or create a new PR. |
|
Closing as it is has merge conflicts and bpo is closed, if required a new PR can be opened or this can reopened. |
Suggested by @vstinner in GH-15424.
https://bugs.python.org/issue23878