Don't skip pickle check_frame_opcodes(). #15025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks like the only place that proto 4 framing gets exercised so leave it as part of the PGO task.
nascheme
added
type-feature
|
Thanks @nascheme for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
I'm having trouble backporting to |
|
Thanks @nascheme for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 30, 2019
This looks like the only place that proto 4 framing gets exercised so leave it as part of the PGO task. (cherry picked from commit eca7ffc) Co-authored-by: Neil Schemenauer <[email protected]>
|
GH-15027 is a backport of this pull request to the 3.8 branch. |
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
This looks like the only place that proto 4 framing gets exercised so leave it as part of the PGO task.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This looks like the only place that proto 4 framing gets exercised so leave it as part of the PGO task.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
This looks like the only place that proto 4 framing gets exercised so leave it as part of the PGO task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like the only place that proto 4 framing gets exercised
so leave it as part of the PGO task.