Add missing space to warning message #14915
Conversation
This was introduced in GH-13409 when changing the message text.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
Oops, thanks ! |
| @@ -47,7 +47,7 @@ def __getattr__(name): | |||
| obj = getattr(_collections_abc, name) | |||
| import warnings | |||
| warnings.warn("Using or importing the ABCs from 'collections' instead " | |||
| "of from 'collections.abc' is deprecated since Python 3.3," | |||
| "of from 'collections.abc' is deprecated since Python 3.3, " | |||
| "and in 3.9 it will stop working", | |||
There was a problem hiding this comment.
This might not be necessary, but it looks like it's also missing a period at the end.
There was a problem hiding this comment.
FWIW looks like most warning messages (grep -R -F -A2 'warnings.warn(' Lib) don't have a trailing dot.
There was a problem hiding this comment.
Oh my mistake then, feel free to disregard that suggestion.
|
@The-Compiler Thanks for the contribution! Yes, this should be backported to 3.8 as well since the space is also missing on that branch. |
|
FWIW I signed the CLA right after opening this PR, but looks like it hasn't been received yet? |
|
@The-Compiler CLA approval usually takes around 24 hours. Sometimes though you have to manually refresh the status on GitHub, use the link from @the-knights-who-say-ni: check yourself. |
|
I'm aware - it's been three days and the checker still says "The-Compiler has not signed CLA". |
|
@The-Compiler The only other option that I'm aware of is sending an email to [email protected] |
|
@aeros167 Thanks, that helped - turns out I somehow have two bugs.python.org accounts ("The-Compiler" from 2012, "The Compiler" from 2014) but never noticed, and they accidentally marked the wrong one. Anything else I need to do at this point? I don't think this needs a news item or issue number FWIW. |
|
@The-Compiler At this point, it's just waiting for a core dev review, they can add a skip news and skip issue label for you. |
rhettinger
added
skip issue
skip news
docs
|
Thanks @The-Compiler for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-15379 is a backport of this pull request to the 3.8 branch. |
This typo was introduced in pythonGH-13409 when changing the message text. (cherry picked from commit c4106af) Co-authored-by: Florian Bruhin <[email protected]>
This typo was introduced in GH-13409 when changing the message text. (cherry picked from commit c4106af) Co-authored-by: Florian Bruhin <[email protected]>
This typo was introduced in pythonGH-13409 when changing the message text.
This typo was introduced in pythonGH-13409 when changing the message text.
This typo was introduced in pythonGH-13409 when changing the message text.
This was introduced in GH-13409 when changing the message text.
cc @Carreau
This should probably go to the 3.8 branch as well?