bpo-37560: Add exception handler in FieldStorage cleanup #14815
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lib/test/test_cgi.py
Outdated
| @@ -363,6 +363,14 @@ def test_fieldstorage_as_context_manager(self): | |||
| with self.assertRaisesRegex(ValueError, 'I/O operation on closed file'): | |||
| fs.file.read() | |||
|
|
|||
| def test_fieldstorage_exit_context(self): | |||
| fs = cgi.FieldStorage() | |||
| try: | |||
There was a problem hiding this comment.
I don't think there's a need to use try / except here in the unit test.
There was a problem hiding this comment.
should I remove it? I was assuming it should assert the test.
nsiregar
force-pushed
the
bpo-37560-exception-handler-exit-field-storage
branch
from
ac98d55 to
c0d3bbd
Compare
benjaminp
reviewed
Sep 11, 2019
| self.file.close() | ||
| try: | ||
| self.file.close() | ||
| except AttributeError: |
There was a problem hiding this comment.
I know this comes from __del__, but can we instead check whether self.file is None before calling close on it?
There was a problem hiding this comment.
I thought it was better to follow EAFP coding style rather than LBYL, do you have any consent why it should check whether self.file is None?
|
Closing as cgi module is deprecated as per PEP 594 and further no improvements or bug fixes will be made to the module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add exception handler on
FieldStorageat__exit__methodhttps://bugs.python.org/issue37560