bpo-37013: Fix the error handling in socket.if_indextoname() #13503

ZackerySpytz · 2019-05-22T16:30:46Z

https://bugs.python.org/issue37013

ZackerySpytz · 2019-05-22T16:33:05Z

I don't think this needs a unit test, mainly because (unsigned long)-1 can vary across platforms.

matrixise

Thank you for your contribution.

zooba · 2019-05-23T15:48:51Z

@matrixise I thought we gave you merge permissions? Want to hit the button? :)

serhiy-storchaka

if_indextoname() takes unsigned int. Therefore highest bits of index can be ignored.

If UINT_MAX < index <= ULONG_MAX -- ignore highest bits.
If ULONG_MAX < index -- OverflowError.

I suggest to handle large index uniformly.

if ((unsigned long)(unsigned int)index != index) {
    PyErr_SetString(OverflowError, "...");
}

ned-deily · 2019-08-29T06:00:44Z

This PR seems to have stalled. @serhiy-storchaka, are you waiting for @ZackerySpytz to address your comments?

serhiy-storchaka · 2019-08-29T08:03:01Z

Yes, I am waiting for addressing my comments.

And please add tests for socket.if_indextoname() called with 2**32-1, 2**32, 2**64-1, 2**64. OSError and OverflowError should be ignored, but the test should not crash.

matrixise · 2019-09-11T16:07:46Z

@matrixise I thought we gave you merge permissions? Want to hit the button? :)

@zoobar yep, with great powers, great responsibilities, but I don't want to crash Python ;-)

@ZackerySpytz could you update your PR with the comments of @serhiy-storchaka ? Thank you

csabella · 2020-01-12T14:04:11Z

@ZackerySpytz, please address the code review comments. Thanks!

csabella · 2020-05-23T15:41:12Z

@serhiy-storchaka, please re-review as I believe your comments have been addressed. Thank you!

miss-islington-app · 2023-12-01T15:16:52Z

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11, 3.12.
🐍🍒⛏🤖

…H-13503) * Fix a crash when pass UINT_MAX. * Fix an integer overflow on 64-bit non-Windows platforms. (cherry picked from commit 0daf555) Co-authored-by: Zackery Spytz <[email protected]>

bedevere-app · 2023-12-01T15:17:01Z

GH-112597 is a backport of this pull request to the 3.12 branch.

bedevere-app · 2023-12-01T15:17:05Z

GH-112598 is a backport of this pull request to the 3.11 branch.

…H-13503) * Fix a crash when pass UINT_MAX. * Fix an integer overflow on 64-bit non-Windows platforms. (cherry picked from commit 0daf555) Co-authored-by: Zackery Spytz <[email protected]>

bedevere-app · 2023-12-01T15:17:13Z

GH-112599 is a backport of this pull request to the 3.10 branch.

bedevere-app · 2023-12-01T15:17:19Z

GH-112600 is a backport of this pull request to the 3.9 branch.

…H-13503) * Fix a crash when pass UINT_MAX. * Fix an integer overflow on 64-bit non-Windows platforms. (cherry picked from commit 0daf555) Co-authored-by: Zackery Spytz <[email protected]>

…H-13503) (GH-112597) * Fix a crash when pass UINT_MAX. * Fix an integer overflow on 64-bit non-Windows platforms. (cherry picked from commit 0daf555) Co-authored-by: Zackery Spytz <[email protected]>

…H-13503) (GH-112598) * Fix a crash when pass UINT_MAX. * Fix an integer overflow on 64-bit non-Windows platforms. (cherry picked from commit 0daf555) Co-authored-by: Zackery Spytz <[email protected]>

miss-islington-app · 2023-12-25T18:56:43Z

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

…H-13503) * Fix a crash when pass UINT_MAX. * Fix an integer overflow on 64-bit non-Windows platforms. (cherry picked from commit 0daf555) Co-authored-by: Zackery Spytz <[email protected]>

bedevere-app · 2023-12-25T18:56:51Z

GH-113474 is a backport of this pull request to the 3.8 branch.

…H-13503) (GH-113474) * Fix a crash when pass UINT_MAX. * Fix an integer overflow on 64-bit non-Windows platforms. (cherry picked from commit 0daf555) Co-authored-by: Zackery Spytz <[email protected]>

…H-13503) (GH-112600) * Fix a crash when pass UINT_MAX. * Fix an integer overflow on 64-bit non-Windows platforms. (cherry picked from commit 0daf555) Co-authored-by: Zackery Spytz <[email protected]>

…H-13503) (GH-112599) * Fix a crash when pass UINT_MAX. * Fix an integer overflow on 64-bit non-Windows platforms. (cherry picked from commit 0daf555) Co-authored-by: Zackery Spytz <[email protected]>

…H-13503) * Fix a crash when pass UINT_MAX. * Fix an integer overflow on 64-bit non-Windows platforms.

the-knights-who-say-ni added the CLA signed label May 22, 2019

bedevere-bot added the awaiting review label May 22, 2019

matrixise added needs backport to 3.7 skip news labels May 23, 2019

matrixise approved these changes May 23, 2019

View reviewed changes

matrixise requested a review from serhiy-storchaka May 23, 2019 08:10

bedevere-bot added awaiting merge and removed awaiting review labels May 23, 2019

serhiy-storchaka reviewed Jun 1, 2019

View reviewed changes

gpshead added the needs backport to 3.8 label Sep 28, 2019

csabella assigned ZackerySpytz Jan 25, 2020

csabella added awaiting changes and removed awaiting merge labels Jan 26, 2020

csabella requested a review from serhiy-storchaka May 23, 2020 15:39

csabella added awaiting change review needs backport to 3.9 and removed awaiting changes labels May 23, 2020

ambv removed needs backport to 3.7 labels May 4, 2021

iritkatriel added the needs backport to 3.10 only security fixes label Oct 17, 2021

iritkatriel approved these changes Oct 17, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Oct 17, 2021

serhiy-storchaka disabled auto-merge December 1, 2023 14:43

serhiy-storchaka enabled auto-merge (squash) December 1, 2023 14:44

serhiy-storchaka merged commit 0daf555 into python:main Dec 1, 2023

bedevere-app bot removed the awaiting merge label Dec 1, 2023

bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 1, 2023

bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 1, 2023

bedevere-app bot removed the needs backport to 3.10 only security fixes label Dec 1, 2023

bedevere-app bot removed the needs backport to 3.9 label Dec 1, 2023

serhiy-storchaka added the needs backport to 3.8 label Dec 25, 2023

bedevere-app bot removed the needs backport to 3.8 label Dec 25, 2023

ZackerySpytz mannequin mentioned this pull request Dec 25, 2023

Fatal Python error in socket.if_indextoname() #81194

Closed

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024

bpo-37013: Fix the error handling in socket.if_indextoname() (pythonG…

f3e7dcd

…H-13503) * Fix a crash when pass UINT_MAX. * Fix an integer overflow on 64-bit non-Windows platforms.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024

bpo-37013: Fix the error handling in socket.if_indextoname() (pythonG…

22ab17e

…H-13503) * Fix a crash when pass UINT_MAX. * Fix an integer overflow on 64-bit non-Windows platforms.

Uh oh!

bpo-37013: Fix the error handling in socket.if_indextoname() #13503

bpo-37013: Fix the error handling in socket.if_indextoname() #13503

Uh oh!

Conversation

ZackerySpytz commented May 22, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZackerySpytz commented May 22, 2019

Uh oh!

matrixise left a comment

Choose a reason for hiding this comment

Uh oh!

zooba commented May 23, 2019

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

ned-deily commented Aug 29, 2019

Uh oh!

serhiy-storchaka commented Aug 29, 2019

Uh oh!

matrixise commented Sep 11, 2019

Uh oh!

csabella commented Jan 12, 2020

Uh oh!

csabella commented May 23, 2020

Uh oh!

miss-islington-app bot commented Dec 1, 2023

Uh oh!

bedevere-app bot commented Dec 1, 2023

Uh oh!

bedevere-app bot commented Dec 1, 2023

Uh oh!

bedevere-app bot commented Dec 1, 2023

Uh oh!

bedevere-app bot commented Dec 1, 2023

Uh oh!

miss-islington-app bot commented Dec 25, 2023

Uh oh!

bedevere-app bot commented Dec 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

ZackerySpytz commented May 22, 2019 •

edited by bedevere-bot

Loading