-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-131093: Enforce -std=c11 for gcc at configure time rather than make time #133608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-131093: Enforce -std=c11 for gcc at configure time rather than make time #133608
Conversation
The following commit authors need to sign the Contributor License Agreement: |
I previously signed the CLA on behalf of my organization, at the direction of the organization's legal department. Is there a way to tell CLA-bot to recognize that? |
cc @ambv re CLA |
🤖 New build scheduled with the buildbot fleet by @AA-Turner for commit b4fbd36 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133608%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
This is my first cpython PR, so I don't know --- do I have any action items from the build failures? E.g., Check if generated files are up to date appears to be checking C code, and this PR doesn't touch any C code. The failures don't appear to be related to this PR's changes, but I'm happy to work on fixes if they are! |
We had some teething issues with the bump to 3.15, so I've updated the branch to check the failures aren't related. In general, you may find the Python Developer's Guide useful. A |
I think redoing the commits with whatever email you signed with and then force-pushing should work. |
…an make time When compiling under gcc, configure.ac currently assumes -std=c11 rather than checking it. This causes configure to succeed but make to fail on old compilers. Fix this by adding a check for -std=c11 in configure.ac.
f14b4f8
to
bc5c9ed
Compare
@ZeroIntensity Thanks! I checked, and the email is the same. However, the author name was different (it was "Chris White" in the commit but "Christopher White" on the CLA). I amended the commit to show the same name as the CLA in case that made a difference. |
I've asked internally for advice. A |
@CS-cwhite, the advice I've had is that you should click the button to sign the CLA again. Sorry for the delay and the trouble this has caused. There's some more background/colour in #120171 (comment) A |
@@ -0,0 +1,3 @@ | |||
On GCC-compatible compilers, check at configure time that ``-std=c11`` | |||
works. This way you don't hit an "invalid option" error at make time on old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works. This way you don't hit an "invalid option" error at make time on old | |
works. This way you don't hit an "invalid option" error at build time on old |
When compiling under gcc, configure.ac currently assumes
-std=c11
rather than checking it. This causes configure to succeed but make to fail on old compilers. Fix this by adding a check for-std=c11
in configure.ac.The changes to
configure
are the result of runningTools/build/regen-configure.sh
.Manual test on gcc 4.4.7:
Before:
After:
Fixes #131093.