gh-132775: Add _PyFunction_GetXIData() #133481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
force-pushed
the
add-pyfunction-getxidata
branch
from
d762347 to
4a195d8
Compare
neonene
reviewed
May 8, 2025
Python/crossinterp_data_lookup.h
Outdated
| if (_PyFunction_VerifyStateless(tstate, func) < 0) { | ||
| PyObject *cause = _PyErr_GetRaisedException(tstate); | ||
| assert(cause != NULL); | ||
| const char *msg = "non-stateless functions are not shareable"; |
There was a problem hiding this comment.
Not confusing, but the triple negation (non, less, not) looks a bit redundant. I do not think NotShareableError needs "not shareable" in the message.
|
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 12, 2025
(cherry picked from commit 8cf4947) Co-authored-by: Eric Snow <[email protected]>
|
GH-133955 is a backport of this pull request to the 3.14 branch. |
|
ericsnowcurrently
added a commit
that referenced
this pull request
May 12, 2025
(cherry picked from commit 8cf4947, AKA gh-133481) Co-authored-by: Eric Snow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is based on gh-133480, thus only the last commit.)