gh-133361: move the explanation of dict equal before its use #133424
Conversation
|
Requesting @terryjreedy , is this what you wanted? |
|
Yes, thanks! |
|
Not quite. I meant to move 5011-3, "Dictionaries compare equal ... TypeError." to the beginning of 4826, "To illustrate,", with the latter part of the same paragraph. I think the latter should be expanded to "To illustrate dict creation and equality,". I think moving the order text and example, as you did, is also good. I will look at the preview after the additional change. |
|
@terryjreedy Hi! I have seen your suggestions. Could you please review again? Thanks! |
|
Please undo 0600d30 - it is not what I said. Please carefully reread what I wrote, which was to move the paragraph on lines 5011 to 5013 that begin with "Dictionaries compare equal" and ends with "`TypeError`." |
This reverts commit 0600d30.
|
Sorry, I did not do it as you said. I reread what you wrote and changed it. |
|
Lines are not allowed to have trailing spaces. It seems that github suggestion editor autoindents when one hits 'Return'. So one should put the cursor at the beginning of the line that should be after the blank, instead of the end of the (indented) line before the blank. |
|
Thanks @Yzi-Li for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…ythonGH-133424) Also move up the explanation of insertion order preservation. Both paragraphs seemed out of place down where they were. --------- (cherry picked from commit 61ac88c) Co-authored-by: Yongzi Li <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
…ythonGH-133424) Also move up the explanation of insertion order preservation. Both paragraphs seemed out of place down where they were. --------- (cherry picked from commit 61ac88c) Co-authored-by: Yongzi Li <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
|
GH-133620 is a backport of this pull request to the 3.14 branch. |
|
GH-133621 is a backport of this pull request to the 3.13 branch. |
…H-133424) (#133620) gh-133361: move the explanation of dict equal before its use (GH-133424) Also move up the explanation of insertion order preservation. Both paragraphs seemed out of place down where they were. --------- (cherry picked from commit 61ac88c) Co-authored-by: Yongzi Li <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
…H-133424) (#133621) gh-133361: move the explanation of dict equal before its use (GH-133424) Also move up the explanation of insertion order preservation. Both paragraphs seemed out of place down where they were. --------- (cherry picked from commit 61ac88c) Co-authored-by: Yongzi Li <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
|
Thank you so much with your help! |
Move the explanation of dict's
==operator before its use.📚 Documentation preview 📚: https://cpython-previews--133424.org.readthedocs.build/