GH-91048: Minor fixes for _remotedebugging & rename to _remote_debugging
#133398
Conversation
AA-Turner
requested review from
a team,
erlend-aasland and
corona10
as code owners
|
Thanks a lot for the fix @AA-Turner! |
Yep, if you want, go ahead and make the changes |
configure.ac
Outdated
| @@ -8077,6 +8077,7 @@ PY_STDLIB_MOD([_gdbm], | |||
| PY_STDLIB_MOD([readline], | |||
| [], [test "$with_readline" != "no"], | |||
| [$READLINE_CFLAGS], [$READLINE_LIBS]) | |||
| PY_STDLIB_MOD([_remotedebugging], [test "$TEST_MODULES" = yes]) | |||
There was a problem hiding this comment.
@pablogsal should we keep this "$TEST_MODULES" = yes condition? It's inherited from before the rename, but I don't know what conditions you want the module to be enabled under.
There was a problem hiding this comment.
Nop, that was from before when this was a test module. Let's remove it
There was a problem hiding this comment.
Ok, I've pushed a fix for this & also the rename to _remote_debugging. Thanks!
AA-Turner
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
AA-Turner
removed request for
a team,
1st1,
asvetlov,
willingc,
corona10,
erlend-aasland and
kumaraditya303
AA-Turner
changed the title
_remotedebugging & rename to _remote_debugging
AA-Turner
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @AA-Turner for commit 2e6b80e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133398%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
# Conflicts: # PCbuild/pcbuild.sln
|
Hummmm, seems that this collided with the other PR, could you rebase? I can land it afterwards. If you don't have time I can rebase myself if you prefer :) |
# Conflicts: # Lib/test/test_external_inspection.py
|
Thanks! resolved conflicts A |
|
Thanks again 🖤 |
cc @pablogsal, a few minor things I spotted after the rename in #133284.
Btw, would you support adding an underscore to the module name? I keep reading it as 'remoted ...', and
_remote_debuggingwould better match the C files.A