Skip to content

gh-132775: Unrevert "Add _PyCode_GetVarCounts()" #133265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented May 1, 2025

This reverts commit 811edcf (gh-133128).

We reverted that change due to failing s390 builds (a big-endian architecture).

(This PR will be the fix, but I'm also using it to diagnose the problem and iterate on the solution, so I can run against the s390 buildbots.)

@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 54b6192 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL8 LTO PR

@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5f6fe84 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL8 LTO PR

@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 39692ea 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL8 LTO PR

@ericsnowcurrently ericsnowcurrently force-pushed the unrevert-add-pycode-get-var-counts branch from 39692ea to 8c83a94 Compare May 2, 2025 02:51
@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 8c83a94 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL8 LTO PR

@ericsnowcurrently ericsnowcurrently force-pushed the unrevert-add-pycode-get-var-counts branch from 8c83a94 to 01bb302 Compare May 2, 2025 03:09
@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 01bb302 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL8 LTO PR

@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO + PGO

@bedevere-bot
Copy link

The regex 's390x RHEL8 LTO + PGO' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 01bb302 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL8 LTO PR

@ericsnowcurrently ericsnowcurrently force-pushed the unrevert-add-pycode-get-var-counts branch from 01bb302 to 97677cb Compare May 2, 2025 06:18
@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 97677cb 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL8 LTO PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 93377fe 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL8 LTO PR

@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 170c354 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL8 LTO PR

@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 0128404 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL8 LTO PR

@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO + PGO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 4fa2ecf 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO \+ PGO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR

@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO + PGO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 4347b13 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO \+ PGO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR

@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO + PGO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit c199564 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO \+ PGO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR

@ericsnowcurrently
Copy link
Member Author

!buildbot s390x RHEL8 LTO + PGO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit c8877e4 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133265%2Fmerge

The command will test the builders whose names match following regular expression: s390x RHEL8 LTO \+ PGO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR

@ericsnowcurrently ericsnowcurrently marked this pull request as ready for review May 5, 2025 18:46
@ericsnowcurrently ericsnowcurrently removed the request for review from markshannon May 5, 2025 18:46
@ericsnowcurrently ericsnowcurrently force-pushed the unrevert-add-pycode-get-var-counts branch from ec03cf0 to 5b3c975 Compare May 5, 2025 18:47
@ericsnowcurrently ericsnowcurrently merged commit 24ebb9c into python:main May 5, 2025
77 checks passed
@ericsnowcurrently ericsnowcurrently deleted the unrevert-add-pycode-get-var-counts branch May 5, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants