Skip to content

gh-133117: Enable stricter mypy checks for tomllib #133206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

gh-133117: Enable stricter mypy checks for tomllib #133206

merged 1 commit into from
May 3, 2025
+8 −10

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 30, 2025 •
edited
Loading

@sobolevn sobolevn added skip news needs backport to 3.13 bugs and security fixes labels Apr 30, 2025
@sobolevn sobolevn requested a review from AlexWaygood April 30, 2025 13:28
@bedevere-app bedevere-app bot mentioned this pull request Apr 30, 2025
Closed
@AlexWaygood
Copy link
Member

I support this but I'm not sure if it makes sense to merge it prior to hukkin/tomli#257? Might it not cause problems if the two codebases get out of sync?

I'll defer to @hukkin / @hauntsaninja / @encukou as the tomllib maintainers :-)

@AlexWaygood AlexWaygood removed their request for review April 30, 2025 13:39
@sobolevn
Copy link
Member Author

sobolevn commented May 1, 2025

hukkin/tomli#257 was merged. The only difference with this PR is that here we still use --incremental, I think it is more important for us, since the scale of the project and the fact that we don't have any extra configs.

cc @hukkin

@sobolevn
Copy link
Member Author

sobolevn commented May 2, 2025

Going to merge this tomorrow :)

@sobolevn sobolevn merged commit cb31741 into python:main May 3, 2025
53 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 3, 2025
@sobolevn @miss-islington
pythongh-133117: Enable stricter mypy checks for tomllib (pythonGH-…
044e36d 
…133206)

(cherry picked from commit cb31741)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 3, 2025

GH-133343 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 3, 2025
sobolevn added a commit that referenced this pull request May 3, 2025
@miss-islington @sobolevn
[3.13] gh-133117: Enable stricter mypy checks for tomllib (GH-133206)…
8525223 
… (#133343)

gh-133117: Enable stricter mypy checks for `tomllib` (GH-133206)
(cherry picked from commit cb31741)

Co-authored-by: sobolevn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja hauntsaninja is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @AlexWaygood