Skip to content

gh-133140: Add PyUnstable_Object_IsUniquelyReferenced for free-threading #133144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 5, 2025
Merged

gh-133140: Add PyUnstable_Object_IsUniquelyReferenced for free-threading #133144

merged 11 commits into from
May 5, 2025

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Apr 29, 2025 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 29, 2025
Closed
@colesbury colesbury mentioned this pull request Apr 30, 2025
Merged
vstinner
vstinner reviewed May 1, 2025
View reviewed changes
vstinner
vstinner reviewed May 1, 2025
View reviewed changes
@encukou
Copy link
Member

encukou commented May 5, 2025

+1, from the API surface point of view

colesbury
colesbury approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit b275b8f into python:main May 5, 2025
46 checks passed
@vstinner
Copy link
Member

vstinner commented May 5, 2025

Merged, thanks.

The Py_REFCNT() documentation might be enhanced to better explain when Py_REFCNT(obj)==1 is acceptable, and the difference between PyUnstable_Object_IsUniquelyReferenced() and PyUnstable_Object_IsUniqueReferencedTemporary(). But that can be done later.

@ZeroIntensity ZeroIntensity deleted the gh-133140-unique-reference branch May 5, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@colesbury colesbury colesbury approved these changes

@encukou encukou Awaiting requested review from encukou

@corona10 corona10 Awaiting requested review from corona10

Assignees
No one assigned
Labels
topic-C-API topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeroIntensity @encukou @vstinner @colesbury