Skip to content

gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject #133039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Apr 27, 2025

@corona10 corona10 changed the title Kumar test gh-132070: use _PyObject_IsUniquelyReferenced in unicodeobject Apr 27, 2025
@corona10
Copy link
Member Author

corona10 commented Apr 27, 2025

@kumaraditya303 @colesbury
I continued working on Kumar's PR #132091. In the new change, more states of unicode_modifiable are observed in free-threading builds. So I added a fallback to use resize_copy when unicode_modifiable fails, but I'm not sure if this is the right approach.
But the test failure issues are resolved.

@corona10 corona10 marked this pull request as ready for review April 27, 2025 10:12
@corona10 corona10 changed the title gh-132070: use _PyObject_IsUniquelyReferenced in unicodeobject gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject Apr 27, 2025
Co-authored-by: Serhiy Storchaka <[email protected]>
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into the case that requires resize_copy: We have an io.StringIO, which is used first by one thread and then by a second thread. (It's not used by two threads simultaneously). The io.StringIO has the only reference to a PyUnicodeWriter, which in turn has the only reference to unicode object that is treated as a buffer.

The _PyObject_IsUniquelyReferenced() check is too conservative in this case because the unicode object is owned by a different thread. The unicode object is actually safe to modify, we just can't tell that from _PyObject_IsUniquelyReferenced().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants