gh-132336: Only mark slow path functions used by the interpreter loop as noinline in free-threaded builds #132424
+30
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in free-threaded builds There is concern that this is slowing down the default build.
chris-eibl
reviewed
Apr 12, 2025
| @@ -374,6 +374,14 @@ extern "C" { | |||
| # define Py_NO_INLINE | |||
| #endif | |||
|
|
|||
| // FT_NO_INLINE | |||
| // Disable inlining of a function only in the free-threaded build. | |||
| #if defined(Py_GIL_DISABLED) | |||
There was a problem hiding this comment.
Referring to Marks comment #132336 (comment)
What we do or do not want to inline depends on whether it is a tail-calling build or not.
this should maybe depend on tail-calling, too?
There was a problem hiding this comment.
Benchmark results suggest that it doesn't matter.
chris-eibl
added
topic-free-threading
performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is concern that this is slowing down the default build.