bpo-36719: regrtest -jN no longer stops on crash #13231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previously, when a test crashed, Python exited immediately. But I prefer to see all errors, to have more info about the bug. For example, if test_asyncio does crash, I would like to know if other tests passed or not. Currently, all following tests are omitted. |
vstinner
changed the title
|
@pablogsal: Do you have an opinion on continuing the execution after a worker crashed? A crash means process killed by a signal, process killed by faulthandler watchdog timeout, etc. |
|
Maybe run a new worker on demand? |
regrtest main process has a pool of thread. Each test file is run in a different thread. When a test file crash, the thread is still consistent and fine. Only the exited process was sick. So I'm not sure of what you mean by "running a new worker". The question is more if we should stop as soon as possible when a test file crash, or if we want to continue. Right now, we stop as soon as possible. I propose to always run the whole test suite. I don't see any technical reason which prevents that, nor why it would be a bad idea. |
|
There is the "failfast" option. I think that if it is set, we should stop as soon as possible. Otherwise we should run a new subprocess instead of the crashed one and continue. |
I think is a good idea as long as there is a way to opt-out of that behaviour, like the "failfast" option that Serhiy mentions. |
--failfast only impacts a single test file. But even if the whole test file fails, regrtest continues the execution. I modified my PR so --failfast now fails as soon as a test file fails. |
"python3 -m test -jN ..." now continues the execution of next tests when a worker process crash (CHILD_ERROR state). Previously, the test suite stopped immediately. Use --failfast to stop at the first error. Moreover, --forever now also implies --failfast.
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 13, 2019
"python3 -m test -jN ..." now continues the execution of next tests when a worker process crash (CHILD_ERROR state). Previously, the test suite stopped immediately. Use --failfast to stop at the first error. Moreover, --forever now also implies --failfast. (cherry picked from commit b0917df) Co-authored-by: Victor Stinner <[email protected]>
|
GH-13291 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
May 13, 2019
"python3 -m test -jN ..." now continues the execution of next tests when a worker process crash (CHILD_ERROR state). Previously, the test suite stopped immediately. Use --failfast to stop at the first error. Moreover, --forever now also implies --failfast. (cherry picked from commit b0917df) Co-authored-by: Victor Stinner <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"python3 -m test -jN ..." now continue the execution of next tests
when a worker process crash (CHILD_ERROR state). Previously, the test
suite stopped immediately. Use --failfast to stop at the first error.
https://bugs.python.org/issue36719