Skip to content

gh-131895: fix $PATH for clang on Darwin runners for tail-calling interpreter #131903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 30, 2025
Merged

gh-131895: fix $PATH for clang on Darwin runners for tail-calling interpreter #131903

merged 4 commits into from
Mar 30, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Mar 30, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 30, 2025
Closed
@picnixz picnixz added the infra CI, GitHub Actions, buildbots, Dependabot, etc. label Mar 30, 2025
@picnixz picnixz force-pushed the infra/fix/tail-calling-interpreter-darwin-clang-131895 branch from 24deed1 to 012e38a Compare March 30, 2025 12:26
@picnixz

This comment was marked as resolved.

Sign in to view
@picnixz picnixz marked this pull request as draft March 30, 2025 12:50
@picnixz picnixz force-pushed the infra/fix/tail-calling-interpreter-darwin-clang-131895 branch from f215493 to e9e9d29 Compare March 30, 2025 13:04
@picnixz
Copy link
Member Author

picnixz commented Mar 30, 2025

Ok... I forgot the $ before {{ hence the error...

@picnixz
Copy link
Member Author

picnixz commented Mar 30, 2025

It works \o/

@picnixz picnixz marked this pull request as ready for review March 30, 2025 13:22
chris-eibl
chris-eibl approved these changes Mar 30, 2025
View reviewed changes
Copy link
Member

@chris-eibl chris-eibl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

So easy once you see the diff but sometimes less easy to get there :)

@picnixz
Copy link
Member Author

picnixz commented Mar 30, 2025

So easy once you see the diff but sometimes less easy to get there :)

Yes. It's always a challenge to review YML code and code where glyphs are hard to distinguish sometimes (like, @${)

@picnixz picnixz enabled auto-merge (squash) March 30, 2025 18:24
@picnixz picnixz merged commit 39fa19a into python:main Mar 30, 2025
44 checks passed
@picnixz picnixz deleted the infra/fix/tail-calling-interpreter-darwin-clang-131895 branch March 31, 2025 00:49
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@picnixz @seehwan80
pythongh-131895: fix clang $PATH on Darwin runners for tail-calling…
905bd15 
… interpreter (python#131903)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@chris-eibl chris-eibl chris-eibl approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees
No one assigned
Labels
infra CI, GitHub Actions, buildbots, Dependabot, etc. skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picnixz @Fidget-Spinner @chris-eibl