gh-131015: Add test for bytes formatting errors

[ApostolFet]

Added test for byte formatting errors as for strings in https://github.com/python/cpython/blob/main/Lib/test/test_str.py#L1581-L1591

• Issue: Add tests for errors during byte formatting as for strings #131015

[picnixz]

Can you make it so that all lines are under 80 chars please? I think the existing code is breaking that limit but I'm not entirely sure. More generally, you could do mod = operator.mod to reduce the overall line length as well.

mod = operator.mod
msg = "...."
self.assertRaisesRegex(TypeError, msg, mod, ...)

Or use a private helper for this test.

[ApostolFet]

What do you think about that option?

        exceptions_params = (
            ('%x format: an integer is required, not float','%x', 3.14),
            ...
        )

        for msg, format, value in exceptions_params:
            self.assertRaisesRegex(TypeError, msg , mod, format, value)

[picnixz]

Yes, something like this is fine. It'll become easier to add more test cases later.

[picnixz]

It could have been possible to also separate the error checks and put them in a separate method but the other tests don't seem to separate the good and the bad cases so let's keep it that way.

We should test bytes and not strings formatting.

[picnixz]

I'll merge this tomorrow.

[miss-islington-app]

Thanks @ApostolFet for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

[miss-islington-app]

Thanks @ApostolFet for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

[miss-islington-app]

Sorry, @ApostolFet and @picnixz, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 05557788f3c284ede73e6f94810ec796bb9d3721 3.12

[miss-islington-app]

Sorry, @ApostolFet and @picnixz, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 05557788f3c284ede73e6f94810ec796bb9d3721 3.13

[picnixz]

I'll make the backports

[bedevere-app]

GH-132114 is a backport of this pull request to the 3.12 branch.

[bedevere-app]

GH-132115 is a backport of this pull request to the 3.13 branch.