GH-131296: fix clang-cl warning on Windows in socketmodule.c #131821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-eibl
commented
Mar 28, 2025
| @@ -3237,7 +3231,7 @@ sock_setsockopt(PyObject *self, PyObject *args) | |||
| &level, &optname, &flag)) { | |||
| #ifdef MS_WINDOWS | |||
| if (optname == SIO_TCP_SET_ACK_FREQUENCY) { | |||
| int dummy; | |||
| DWORD dummy; | |||
There was a problem hiding this comment.
fix warning : incompatible pointer types passing 'int *' to parameter of type 'LPDWORD' (aka 'unsigned long *') [-Wincompatible-pointer-types]
chris-eibl
commented
Mar 28, 2025
| @@ -6066,8 +6060,10 @@ socket_gethostbyname_ex(PyObject *self, PyObject *args) | |||
| #ifdef USE_GETHOSTBYNAME_LOCK | |||
| PyThread_acquire_lock(netdb_lock, 1); | |||
| #endif | |||
| SUPPRESS_DEPRECATED_CALL | |||
| _Py_COMP_DIAG_PUSH | |||
There was a problem hiding this comment.
The rest of the PR cares about deprecation warnings like
..\Modules\socketmodule.c(6070,9): warning : 'gethostbyname' is deprecated:
Use getaddrinfo() or GetAddrInfoW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS
to disable deprecated API warnings [-Wdeprecated-declarations]
https://github.com/python/cpython/actions/runs/14044831663/job/39366560293?pr=131690#step:4:183
using the already existing infrastructure _Py_COMP_DIAG_PUSH et al. from pyport.h, because clang-cl unfortunately does not (yet) respect
# define SUPPRESS_DEPRECATED_CALL __pragma(warning(suppress: 4996))
|
I am pretty sure that failing of Ubuntu (free-threading) / build and test (ubuntu-24.04) (pull_request) is unrelated to the PR. |
|
All commit authors signed the Contributor License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a skip news?