gh-131719: add NULL ptr check to _PyMem_FreeDelayed #131720

tom-pytel · 2025-03-25T13:55:50Z

Self explanatory.

Issue: _PyMem_FreeDelayed() missing a NULL pointer check #131719

tom-pytel · 2025-03-25T14:20:50Z

Ping @colesbury

miss-islington-app · 2025-03-25T14:49:25Z

Thanks @tom-pytel for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

…ongh-131720) (cherry picked from commit 0a91456) Co-authored-by: Tomasz Pytel <[email protected]>

bedevere-app · 2025-03-25T14:49:38Z

GH-131722 is a backport of this pull request to the 3.13 branch.

…131720) (gh-131722) (cherry picked from commit 0a91456) Co-authored-by: Tomasz Pytel <[email protected]>

bedevere-bot · 2025-03-25T16:23:26Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable 3.x (tier-2) has failed when building commit 0a91456.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/125/builds/7250) and take a look at the build logs.
Check if the failure is related to this commit (0a91456) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/125/builds/7250

Failed tests:

test_perf_profiler

Failed subtests:

test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated
test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/test/test_perf_profiler.py", line 388, in test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 466 events and lost 1[34 chars]\n\n' != ''
- Warning:
- Processed 466 events and lost 1 chunks!
- 
- Check IO/CPU overload!
- 


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/test/test_perf_profiler.py", line 364, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python_c4e__z4e/tmpls1xr9ag/perftest.py' not found in 'python 3436252 75173.811583:          1 cycles:Pu: \n\t    ffff9edeaac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3436252 75173.811614:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffff9edeaac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3436252 75173.812075:          1 cycles:Pu: \n\t    ffff9ede1a30 _dl_load_cache_lookup+0x148 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9edd72c3 _dl_map_object+0x377 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9edd25bf openaux+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9edd1303 _dl_catch_exception+0x63 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9edd2b33 _dl_map_object_deps+0x553 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9ede819f dl_main+0x139f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9ede55ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9ede6b17 _dl_start_final+0x5ab (inlined)\n\t    ffff9ede6b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9edeaad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3436252 75173.812100:        331 cycles:Pu: \n\t    ffff9ede1a34 _dl_load_cache_lookup+0x14c (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9edd72c3 _dl_map_object+0x377 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9edd25bf openaux+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9edd1303 _dl_catch_exception+0x63 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9edd2b33 _dl_map_object_deps+0x553 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9ede819f dl_main+0x139f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9ede55ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9ede6b17 _dl_start_final+0x5ab (inlined)\n\t    ffff9ede6b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9edeaad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3436252 75173.813096:       1196 cycles:Pu: 
thread_ident+0xb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e7ee96f _PyRuntimeState_Init+0xcf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\npython 3436252 75173.815587:    1488024 cycles:Pu: \n\t    ffff9e7a717c type_ready_set_type+0x0 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e864533 type_ready+0x57 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e950d6f init_static_type+0x1a7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e950e73 _PyStaticType_InitBuiltin+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e950fc7 _PyTypes_InitTypes+0xa7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9ea56c8f pycore_init_types+0x1b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9ea57fab pycore_interp_init+0x10b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9ea5ca27 pyinit_config+0xaf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9ea6ed57 pyinit_core+0xdb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9ea6f587 Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9ea6fb4f pymain_init+0xff (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9ea6fb83 pymain_main+0xf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9ea6fc17 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t          400877 main+0xb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/python)\n\t    ffff9e49625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff9e49633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          40076f _start+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/python)\n\npython 3436252 75173.817323:    3753821 cycles:Pu: \n\t    ffff9e7d45a0 Py_INCREF.lto_priv.11+0x4 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e8dd76f Py_XINCREF+0x33 (inlined)\n\t    ffff9e8dd76f _Py_XNewRef+0x33 (inlined)\n\t    ffff9e8dd76f descr_new+0x33 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e8ddb23 PyDescr_NewWrapper+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e8ddb9b add_operators+0x5f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e8e6683 type_ready_fill_dict+0x13 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e86456f type_ready+0x93 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e950d6f init_static_type+0x1a7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e950e73 _PyStaticType_InitBuiltin+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9e950fc7 _PyTypes_InitTypes+0xa7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffff9ea56c8f pycore_init_types+0x1b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/lib


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/test/test_perf_profiler.py", line 364, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python_0zj88gi_/tmp9kqvbadh/perftest.py' not found in 'python 3446017 75374.166924:          1 cycles:Pu: \n\t    ffffbbd90ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3446017 75374.166955:          1 cycles:Pu: \n\t    ffffbbd90ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3446017 75374.167079:          1 cycles:Pu: \n\t    ffffbbd8c688 elf_get_dynamic_info+0x11c (inlined)\n\t    ffffbbd8c688 _dl_start+0x11c (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbbd90ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3446017 75374.167100:        415 cycles:Pu: \n\t    ffffbbd8c7f8 _dl_start+0x28c (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbbd90ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3446017 75374.168187:       4573 cycles:Pu: \n\t    ffffbbd825a4 elf_dynamic_do_Rela+0x644 (inlined)\n\t    ffffbbd825a4 _dl_relocate_object+0x644 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbbd8e44f dl_main+0x164f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbbd8b5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbbd8cb17 _dl_start_final+0x5ab (inlined)\n\t    ffffbbd8cb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbbd90ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3446017 75374.168538:     249667 cycles:Pu: \n\t    ffffbbd82624 elf_dynamic_do_Rela+0x6c4 (inlined)\n\t    ffffbbd82624 _dl_relocate_object+0x6c4 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbbd8e44f dl_main+0x164f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbbd8b5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbbd8cb17 _dl_start_final+0x5ab (inlined)\n\t    ffffbbd8cb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbbd90ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3446017 75374.169848:     508935 cycles:Pu: \n\t    ffffbb771fac _Py_GetEnv+0x0 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffffbb79a88b _PyPreCmdline_Read+0x113 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffffbb79a96f preconfig_read+0x2b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffffbba0892b _PyPreConfig_Read+0x287 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffffbba08a87 _Py_PreInitializeFromPyArgv+0x103 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffffbba1faa7

…ongh-131720)

pythongh-131719: add NULL ptr check to _PyMem_FreeDelayed

fe8caf8

bedevere-app bot added the awaiting review label Mar 25, 2025

bedevere-app bot mentioned this pull request Mar 25, 2025

_PyMem_FreeDelayed() missing a NULL pointer check #131719

Closed

blurb-it bot and others added 2 commits March 25, 2025 13:58

📜🤖 Added by blurb_it.

20d9029

fix news

354328c

tom-pytel mentioned this pull request Mar 25, 2025

gh-128942: make arraymodule.c free-thread safe (lock-free) #130771

Open

colesbury approved these changes Mar 25, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Mar 25, 2025

colesbury added the needs backport to 3.13 bugs and security fixes label Mar 25, 2025

colesbury merged commit 0a91456 into python:main Mar 25, 2025
48 checks passed

bedevere-app bot removed the awaiting merge label Mar 25, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2025

pythongh-131719: add NULL pointer check to _PyMem_FreeDelayed (pyth…

cbd4749

…ongh-131720) (cherry picked from commit 0a91456) Co-authored-by: Tomasz Pytel <[email protected]>

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 25, 2025

tom-pytel deleted the fix-issue-131719 branch March 25, 2025 15:00

colesbury pushed a commit that referenced this pull request Mar 25, 2025

[3.13] gh-131719: add NULL pointer check to _PyMem_FreeDelayed (gh-…

9c7ef0c

…131720) (gh-131722) (cherry picked from commit 0a91456) Co-authored-by: Tomasz Pytel <[email protected]>

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025

pythongh-131719: add NULL pointer check to _PyMem_FreeDelayed (pyth…

8014cf0

…ongh-131720)

seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025

pythongh-131719: add NULL pointer check to _PyMem_FreeDelayed (pyth…

25a6be4

…ongh-131720)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-131719: add NULL ptr check to _PyMem_FreeDelayed #131720

gh-131719: add NULL ptr check to _PyMem_FreeDelayed #131720

Uh oh!

tom-pytel commented Mar 25, 2025 •

edited by bedevere-app bot

Loading

Uh oh!

tom-pytel commented Mar 25, 2025

Uh oh!

Uh oh!

miss-islington-app bot commented Mar 25, 2025

Uh oh!

bedevere-app bot commented Mar 25, 2025

Uh oh!

bedevere-bot commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

gh-131719: add NULL ptr check to _PyMem_FreeDelayed #131720

gh-131719: add NULL ptr check to _PyMem_FreeDelayed #131720

Uh oh!

Conversation

tom-pytel commented Mar 25, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tom-pytel commented Mar 25, 2025

Uh oh!

Uh oh!

miss-islington-app bot commented Mar 25, 2025

Uh oh!

bedevere-app bot commented Mar 25, 2025

Uh oh!

bedevere-bot commented Mar 25, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

tom-pytel commented Mar 25, 2025 •

edited by bedevere-app bot

Loading