Skip to content

gh-111178: Fix function signatures in odictobject.c #131160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 12, 2025

Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to also make similar changes as I did in my PRs, for the NOARGS method, I renamed the ignored parameter to dummy and for METH_O ones, I named it arg so that by reading the function itself, we can know how it's used (I found "ignored" confusing as we already have Py_UNUSED...).

If you find it bothersome or don't think it adds value, feel free to ignore this suggestion.

@vstinner
Copy link
Member Author

If you want to also make similar changes as I did in my PRs, for the NOARGS method, I renamed the ignored parameter to dummy and for METH_O ones, I named it arg so that by reading the function itself, we can know how it's used (I found "ignored" confusing as we already have Py_UNUSED...).

I'm fine with "ignored", so I prefer to leave these parameters as they are :-)

@vstinner vstinner enabled auto-merge (squash) March 13, 2025 09:53
@vstinner vstinner merged commit d12d8c5 into python:main Mar 13, 2025
41 checks passed
@vstinner vstinner deleted the ubsan_odict branch March 13, 2025 10:15
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants