GH-130614: pathlib ABCs: revise test suite for readable paths #131018
+759
−268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test `pathlib.types._ReadablePath` in a dedicated test module. These tests cover `ReadableZipPath`, `ReadableLocalPath` and `Path`, where the former two classes are implementations of `_ReadablePath` for use in tests.
17 tasks
barneygale
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @barneygale for commit 65dcc8b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131018%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
pathlib.types._ReadablePathin a dedicated test module. These tests coverReadableZipPath,ReadableLocalPathandPath, where the former two classes are implementations of_ReadablePathfor use in tests.The
ReadableZipPathimplementation is reasonably complex because it supports following symlinks when resolving paths. Recording symlinks in.zipfiles isn't widely supported, so this feature would probably never be added to a practical implementation ofReadableZipPath, but it's useful for testing.pathlib.Path.copy()#130614