Skip to content

gh-130673: Gracefully handle section in jit build #130906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

gh-130673: Gracefully handle section in jit build #130906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9184dbf
gh-130673: Gracefully handle section in jit build
rennsax Mar 6, 2025
87334a4
Add a blurb entry under `Misc/NEWS.d`
rennsax Mar 6, 2025
97c01de
Add a comment for explaining
rennsax Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Build/2025-03-06-20-55-34.gh-issue-130673.T3RSCI.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix potential ``KeyError`` when handling object sections during JIT building
process.
6 changes: 5 additions & 1 deletion Tools/jit/_targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,11 @@ def _handle_section(
if section_type == "SHT_RELA":
assert "SHF_INFO_LINK" in flags, flags
assert not section["Symbols"]
value, base = group.symbols[section["Info"]]
maybe_symbol = group.symbols.get(section["Info"])
if maybe_symbol is None:
# These are relocations for a section we're not emitting. Skip:
return
value, base = maybe_symbol
if value is _stencils.HoleValue.CODE:
stencil = group.code
else:
Expand Down
Loading