-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-129666: Add C11/C++11 to docs and -pedantic-errors
to GCC/clang test_c[pp]ext tests
#130686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM. I trust that it works, but the wording and suppressions match what I expected/hoped/wanted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It's a bit unfortunate that it's not possible to build a Python C extension with -pedantic, but test_cext purpose is to test the Python C API (check that it doesn't emit warnings), not test the C extension itself. So I'm fine with ignoring -pedantic warnings on a few lines of the C extension.
Thank you for the reviews!
Well, I want to fix that too :) |
|
|
|
|
Buildbots are grumpy. Example:
|
|
The |
I'll revert and test harder. |
… to GCC/clang test_c[pp]ext tests (pythonGH-130686)" This reverts commit 003e6d2.
Oh, looks like |
I think I failed to run GCC again after testing with clang :( |
|
|
|
|
|
|
|
|
|
…clang test_c[pp]ext tests (pythonGH-130686)
…clang test_c[pp]ext tests (pythonGH-130686)
…clang test_c[pp]ext tests (pythonGH-130686)
…-pedantic-errors` to GCC/clang test_c[pp]ext tests (pythonGH-130686)" (pythonGH-130688) This reverts commit 003e6d2.
Ask GCC/clang to more strictly validate compliance with the standards.
Add opt-outs where currently necessary.
Add a C/C++ version note to docs.
📚 Documentation preview 📚: https://cpython-previews--130686.org.readthedocs.build/