-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-111178: Change Argument Clinic signature for METH_O #130682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use "PyObject*" for METH_O functions to fix an undefined behavior.
@erlend-aasland: Would you mind to review this change? Focus on the first and third commit, the second one only updates generated code. This change is a follow-up of PR #128447 (commit 537296c). Example with
which is the correct signature for methods: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manual modifications look correct to me but for the AC part I don't know if there are more assumptions I'm not aware of.
…130682) Use "PyObject*" for METH_O functions to fix an undefined behavior.
Use "PyObject*" for METH_O functions to fix an undefined behavior.