GH-130614: Add test suites for readable and writable pathlib paths
#130648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paths Add `test.test_pathlib.test_read`, which tests `ReadablePath` subclasses. Tests are run against `ReadableZipPath`, `ReadableLocalPath`, and `Path`. This test suite is mostly incomplete. Add `test.test_pathlib.test_write`, which tests `WritablePath` subclasses. Tests are run against `WritableZipPath`, `WritableLocalPath`, and `Path`. This test suite is mostly complete. Add `test.test_pathlib.support.zip_path`, which provides the `*ZipPath` classes mentioned above. It also provides a `ZipPathGround` class that's used by tests to make assertions about the contents of the zip file. Add `test.test_pathlib.support.local_path`, which provides the `*LocalPath` classes mentioned above. They're stripped-back versions of `pathlib.Path`, basically. It also provides `LocalPathGround` class that's used by tests to access the local filesystem.
barneygale
commented
Feb 27, 2025
|
@srinivasreddy here's a framework for copy tests - see |
|
@barneygale You have made significant progress, i do not think it would be right for me to start working on this. I will find something else to work on. Thanks 🙏🏾 |
|
Closing this PR - I've split it into several other PRs attached to the same issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
test.test_pathlib.test_read, which testsReadablePathsubclasses. Tests are run againstReadableZipPath,ReadableLocalPath, andPath. This test suite is mostly incomplete.Add
test.test_pathlib.test_write, which testsWritablePathsubclasses. Tests are run againstWritableZipPath,WritableLocalPath, andPath. This test suite is mostly complete.Add
test.test_pathlib.support.zip_path, which provides the*ZipPathclasses mentioned above. It also provides aZipPathGroundclass that's used by tests to make assertions about the contents of the zip file.Add
test.test_pathlib.support.local_path, which provides the*LocalPathclasses mentioned above. They're stripped-back versions ofpathlib.Path, basically. It also providesLocalPathGroundclass that's used by tests to access the local filesystem.pathlib.Path.copy()#130614