Skip to content

gh-111178: Fix function signatures in sliceobject.c #130575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2025
Merged

gh-111178: Fix function signatures in sliceobject.c #130575

merged 2 commits into from
Feb 26, 2025
+17 −9

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 26, 2025 •
edited by bedevere-app bot
Loading

@vstinner
pythongh-111178: Fix function signatures in sliceobject.c
a5584f6 
Rename slicehash() to slice_hash() for consistency.
@bedevere-app bedevere-app bot mentioned this pull request Feb 26, 2025
Closed
@vstinner
Copy link
Member Author

cc @picnixz

skirpichev
skirpichev reviewed Feb 26, 2025
View reviewed changes
Copy link
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see just one slice_traverse() slot with type cast. Would you mind to fix this too?

@vstinner
Copy link
Member Author

I see just one slice_traverse() slot with type cast. Would you mind to fix this too?

Alright, I updated my PR to also change this function.

@vstinner vstinner merged commit daeb0ef into python:main Feb 26, 2025
41 checks passed
@vstinner vstinner deleted the ubsan_slice branch February 26, 2025 20:37
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@vstinner @seehwan80
pythongh-111178: Fix function signatures in sliceobject.c (python#130575
387c8bb 
)

Rename slicehash() to slice_hash() for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @skirpichev