gh-111178: fix UBSan failures in Modules/_functoolsmodule.c
#129778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, change `_PyPartialObject_CAST` to `partialobject_CAST` as `_` + capital letter is UB.
encukou
reviewed
Feb 18, 2025
| @@ -145,7 +145,7 @@ typedef struct { | |||
| } partialobject; | |||
|
|
|||
| // cast a PyObject pointer PTR to a partialobject pointer (no type checks) | |||
| #define _PyPartialObject_CAST(PTR) ((partialobject *)(PTR)) | |||
| #define partialobject_CAST(op) ((partialobject *)(op)) | |||
There was a problem hiding this comment.
There' no need to change existing macros, especially ones with the _Py prefix that's de-facto reserved for Python.
There was a problem hiding this comment.
Err actually this is something I probably wrote recently so I thought it would have been better to make it consistent at least. I can revert it though (I think that's my code because there is a PTR and this is something I used before Victor told me to use "op")
There was a problem hiding this comment.
Oh, right, it's from #124733 from October
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.